From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sat, 06 Feb 2016 00:46:15 GMT
Subject: Re: [PATCHv8 3/9] submodule-config: remove name_and_item_from_var
Message-ID: <20160206004615.GB28749@google.com>
In-Reply-To: <1454623776-3347-4-git-send-email-sbeller@google.com>

Hi,

Stefan Beller wrote:

> --- a/submodule-config.c
> +++ b/submodule-config.c
> @@ -251,18 +235,19 @@ static int parse_config(const char *var, const char *value, void *data)
>  {
>  	struct parse_config_parameter *me = data;
>  	struct submodule *submodule;
> -	struct strbuf name = STRBUF_INIT, item = STRBUF_INIT;
> -	int ret = 0;
> +	int subsection_len, ret = 0;
> +	const char *subsection, *key;
>  
> -	/* this also ensures that we only parse submodule entries */
> -	if (!name_and_item_from_var(var, &name, &item))
> +	if (parse_config_key(var, "submodule", &subsection,
> +			     &subsection_len, &key) < 0 || !subsection)
>  		return 0;
>  
> +	subsection = xmemdupz(subsection, subsection_len);

This appears to be leaked.

Thanks,
Jonathan