From: Patrick Steinhardt Date: Tue, 02 Feb 2016 12:00:03 GMT Subject: Re: [PATCH v4 07/15] remote: die on config error when setting URL Message-ID: <20160202120003.GA22942@pks-pc.localdomain> In-Reply-To: <1454413916-31984-8-git-send-email-ps@pks.im> On Tue, Feb 02, 2016 at 12:51:48PM +0100, Patrick Steinhardt wrote: > When invoking `git-remote --set-url` we do not check the return > value when writing the actual new URL to the configuration file, > pretending to the user that the configuration has been set while > it was in fact not persisted. > > Fix this problem by dying early when setting the config fails. > > Signed-off-by: Patrick Steinhardt Signed-off-by: Patrick Steinhardt Sorry, borked up that signed-off-by. Will fix in a later revision (which I guess will be necessary anyway ;). Patrick