From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Mon, 18 Jan 2016 22:35:00 GMT
Subject: Re: [PATCH v2 5/5] ls-remote: add support for showing symrefs
Message-ID: <20160118223500.GK7100@hank>
In-Reply-To: <20160118222012.GA24740@sigill.intra.peff.net>

On 01/18, Jeff King wrote:
> On Mon, Jan 18, 2016 at 11:09:13PM +0100, Thomas Gummerer wrote:
>
> > > +test_expect_failure 'ls-remote with filtered symrefs (--heads)' '
> > > +	git symbolic-ref refs/heads/foo refs/tags/mark &&
> > > +	cat >expect <<-\EOF &&
> > > +	ref: refs/heads/bar	refs/tags/mark
> > > +	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/foo
> > > +	1bd44cb9d13204b0fe1958db0082f5028a16eb3a	refs/heads/master
> > > +	EOF
> > > +	git ls-remote --symrefs --heads . >actual &&
> > > +	test_cmp expect actual
> > > +'
> >
> > I'm a bit confused by this.  Shouldn't the "ref: refs/heads/bar
> > refs/tags/mark" line only show up when we use --tags, not --heads?
> > Also should refs/heads/bar be refs/heads/foo?
>
> Yes, sorry, I bungled this. It should expect:
>
>   ref: refs/tags/mark\trefs/heads/foo
>
> I changed my mind about which refs to use halfway through writing, and
> of course because it is marked to expect failure, running the test
> didn't clue me in. :)

Heh, thanks for clearing this up :-)

> -Peff

--
Thomas