From: Jeff King Date: Fri, 15 Jan 2016 19:10:51 GMT Subject: Re: [PATCH v4 00/21] Peace with CRLF Message-ID: <20160115191051.GA11301@sigill.intra.peff.net> In-Reply-To: <1452815916-6447-1-git-send-email-gitster@pobox.com> On Thu, Jan 14, 2016 at 03:58:15PM -0800, Junio C Hamano wrote: > - The update to mktree used "lf_lines" in the preview, but this > version flips it to the same "nul_term_line" to match other two, > even though I think the latter is a terrible variable name with > bad taste. Heh. I also dislike that variable name, but not want to nit-pick when reading the preview. I think just "use_nul_terminator" or something would be fine. It is really the "line" which bugs me, because they are not really lines anymore. -Peff