From: Jeff King Date: Tue, 12 Jan 2016 13:26:28 GMT Subject: Re: [PATCH v2 2/2] lock_ref_sha1_basic: handle REF_NODEREF with invalid refs Message-ID: <20160112132628.GA31854@sigill.intra.peff.net> In-Reply-To: <20160112095804.GB16501@sigill.intra.peff.net> On Tue, Jan 12, 2016 at 04:58:04AM -0500, Jeff King wrote: > +test_expect_failure 'checkout away from d/f HEAD (to branch)' ' > + reset_to_df && > + git checkout master > +' > + > +test_expect_failure 'checkout away from d/f HEAD (to detached)' ' > + reset_to_df && > + git checkout --detach master > +' These should be expect_success, of course (I had originally planned to introduce the tests and then fix them later, but it all ended up in the same patch). Unfortunately, I think there is a case we're missing. I'm still digging, but hope to have something soon. In the meantime, don't bother with v2. :) -Peff