From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 06 Jan 2016 00:23:33 GMT
Subject: Re: Segmentation fault found while fuzzing .pack file under 2.7.0.rc3
Message-ID: <20160106002333.GA16090@google.com>
In-Reply-To: <20160105152436.GA1205@sigill.intra.peff.net>

Jeff King wrote:

> Git packfiles come from two places:
>
>   1. Local maintenance repacks loose and already-packed objects into a
>      new packfile. We trust the local repack process to generate a valid
>      packfile (though the contents of individual objects may be
>      untrusted, of course).

I think we should reconsider such trust.  If one user creates a
malicious pack, if another user uses read-only git commands to access
the repository (after inspecting .git/config to make sure it doesn't
contain anything scary) the result should not be arbitrary code
execution.

Producing bogus output or aborting is okay; arbitrary code execution
less so.

Thanks,
Jonathan