From: Jeff King <peff@peff.net>
Date: Wed, 30 Dec 2015 06:57:28 GMT
Subject: Re: [PATCH v2 0/3] improve symbolic-ref robustness
Message-ID: <20151230065728.GB26964@sigill.intra.peff.net>
In-Reply-To: <xmqqpoxpgd7p.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 29, 2015 at 01:24:42PM -0800, Junio C Hamano wrote:

> > The patches are:
> >
> >   [1/3]: create_symref: modernize variable names
> >   [2/3]: create_symref: use existing ref-lock code
> >   [3/3]: create_symref: write reflog while holding lock
> 
> This is queued as an early part of 'pu', and some refactoring in
> David's refs-backend-lmdb topic conflicts with it when merged to
> 'pu'.  I think I resolved the conflicts correctly, but please double
> check the result when I push it out later today.

Looks sane to me. It seems like the change was just the renaming of the
functions. We _could_ match the renaming of the static-local functions
(e.g., create_symref_locked would become files_create_symref_locked),
but I don't think it's necessary for file-local functions.

-Peff