From: Jeff King Date: Tue, 15 Dec 2015 23:25:35 GMT Subject: Re: [PATCH 1/3] prepare_packed_git(): find more garbage Message-ID: <20151215232534.GA30998@sigill.intra.peff.net> In-Reply-To: <20151215230957.GA30353@sigill.intra.peff.net> On Tue, Dec 15, 2015 at 06:09:57PM -0500, Jeff King wrote: > > @@ -1225,6 +1225,15 @@ static void report_helper(const struct string_list *list, > [...] > If I understand this function correctly, we're just trying to > get rid of "boring" cases that do not need to be reported. BTW, I wondered if this should perhaps just be calling bits_to_msg() and seeing if it returns NULL. It seems like the logic for which cases are "interesting" ends up duplicated. But maybe I am missing something. -Peff