From: Jeff King <peff@peff.net>
Date: Mon, 07 Dec 2015 20:44:40 GMT
Subject: Re: [PATCH] filter-branch: pass tag name via stdin without newline
Message-ID: <20151207204440.GC30203@sigill.intra.peff.net>
In-Reply-To: <xmqqd1ujnf1i.fsf@gitster.mtv.corp.google.com>

On Sun, Dec 06, 2015 at 06:55:21PM -0800, Junio C Hamano wrote:

> "Eric N. Vander Weele" <ericvw@gmail.com> writes:
> 
> > "git filter-branch --tag-name-filter" fails when the user-provided
> > command attempts to trivially append text to the originally tag name,
> > passed via stdin, due to an unexpected newline ('\n').  The newline is
> > introduced due to "echo" piping the original tag name to the
> > user-provided tag name filter command.
> 
> Is there any other place where we feed such an incomplete line
> (i.e. a line without the terminating LF) to the filters in this
> command?

I suspect we would break filters if we did. On some systems, tools like
`sed` and `tr` often behave funny when there is no trailing newline, but
I do not recall all of the specific instances (if one felt like engaging
in some light masochism, searching the mailing list archive will
probably turn up results).

-Peff