From: Jeff King <peff@peff.net>
Date: Fri, 20 Nov 2015 11:44:38 GMT
Subject: Re: [PATCH] Escape Git's exec path in contrib/rerere-train.sh script
Message-ID: <20151120114438.GH11198@sigill.intra.peff.net>
In-Reply-To: <1446982075-26161-1-git-send-email-knittl89+git@googlemail.com>

On Sun, Nov 08, 2015 at 12:27:55PM +0100, Daniel Knittl-Frank wrote:

> Whitespace can cause the source command to fail. This is usually not a
> problem on Unix systems, but on Windows Git is likely to be installed
> under "C:/Program Files/", thus rendering the script broken.
> 
> Signed-off-by: Daniel Knittl-Frank <knittl89+git@googlemail.com>
> ---
>  contrib/rerere-train.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh
> index 36b6fee..52ad9e4 100755
> --- a/contrib/rerere-train.sh
> +++ b/contrib/rerere-train.sh
> @@ -7,7 +7,7 @@ USAGE="$me rev-list-args"
>  
>  SUBDIRECTORY_OK=Yes
>  OPTIONS_SPEC=
> -. $(git --exec-path)/git-sh-setup
> +. "$(git --exec-path)/git-sh-setup"

Thanks, this makes sense.

The "normal" scripts just use ". git-sh-setup", but they have the
benefit of being run under the "git" wrapper, so the exec-path is
already in their PATH. This one is meant to be used directly, so it
needs this.

-Peff