From: Jeff King <peff@peff.net>
Date: Fri, 20 Nov 2015 11:38:30 GMT
Subject: Re: [PATCH v4 09/12] Add several uses of get_object_hash.
Message-ID: <20151120113830.GF11198@sigill.intra.peff.net>
In-Reply-To: <1447122150-672570-10-git-send-email-sandals@crustytoothpaste.net>

On Tue, Nov 10, 2015 at 02:22:27AM +0000, brian m. carlson wrote:

> diff --git a/patch-ids.c b/patch-ids.c
> index bf81b923..83229a0d 100644
> --- a/patch-ids.c
> +++ b/patch-ids.c
> @@ -8,10 +8,10 @@ static int commit_patch_id(struct commit *commit, struct diff_options *options,
>  		    unsigned char *sha1)
>  {
>  	if (commit->parents)
> -		diff_tree_sha1(commit->parents->item->object.sha1,
> -		               commit->object.sha1, "", options);
> +		diff_tree_sha1(get_object_hash(commit->parents->item->object),
> +		               get_object_hash(commit->object), "", options);

I haven't looked carefully at this series yet, but while applying I
noticed that git complained about whitespace here (long run of spaces
which could be using tabs).

I've fixed it up for what I'm queuing, but you may want to do so
locally, too.

-Peff