From: Jeff King <peff@peff.net>
Date: Fri, 20 Nov 2015 11:13:14 GMT
Subject: Re: [PATCH 2/2] fsck: treat a NUL in a tag header as an error
Message-ID: <20151120111312.GA11198@sigill.intra.peff.net>
In-Reply-To: <564DF7FB.3090704@web.de>

On Thu, Nov 19, 2015 at 05:25:31PM +0100, René Scharfe wrote:

> We check the return value of verify_header() for commits already, so do
> the same for tags as well.
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  fsck.c          | 3 ++-
>  t/t1450-fsck.sh | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fsck.c b/fsck.c
> index e41e753..4060f1f 100644
> --- a/fsck.c
> +++ b/fsck.c
> @@ -711,7 +711,8 @@ static int fsck_tag_buffer(struct tag *tag, const char *data,
>  		}
>  	}
>  
> -	if (verify_headers(buffer, size, &tag->object, options))
> +	ret = verify_headers(buffer, size, &tag->object, options);
> +	if (ret)
>  		goto done;

Good catch. The patch look reasonable to me.

-Peff