From: Jeff King <peff@peff.net>
Date: Tue, 17 Nov 2015 22:48:10 GMT
Subject: Re: [PATCH v2] blame: avoid checking if a file exists on the working tree if a revision is provided
Message-ID: <20151117224809.GE27862@sigill.intra.peff.net>
In-Reply-To: <CAPig+cTjg8yvmLO0uuWZt4nATUnfxJOj4f_AmvRP9mHsGRmEOg@mail.gmail.com>

On Tue, Nov 17, 2015 at 12:11:25AM -0500, Eric Sunshine wrote:

> > blame content even if the path provided does match an existing
> > blob on said revision.
> 
> git-blame documentation does not advertise "blame <file> <rev>" as a
> valid invocation. It does advertise "blame <rev> -- <file>", and this
> case already works correctly even when <file> does not exist in the
> worktree.

Hmm. Out of curiosity I tried:

  git blame v2.4.0 -- t/t6031-merge-recursive.sh

and it segfaults. This bisects to Max's recent 1b0d400 (blame: extract
find_single_final, 2015-10-30), but I do not see anything obviously
wrong with it from a quick glance.

-Peff