From: Jeff King <peff@peff.net>
Date: Wed, 04 Nov 2015 06:40:21 GMT
Subject: Re: [PATCH v4] Add git-grep threads param
Message-ID: <20151104064021.GB16605@sigill.intra.peff.net>
In-Reply-To: <xmqqvb9jc81q.fsf@gitster.mtv.corp.google.com>

On Tue, Nov 03, 2015 at 09:22:09AM -0800, Junio C Hamano wrote:

> > +grep.threads::
> > +	Number of grep worker threads, use it to tune up performance on
> > +	multicore machines. Default value is 8. Set to 0 to disable threading.
> > +
> 
> I am not enthused by this "Set to 0 to disable".  As Zero is
> magical, it would be more useful if 1 meant that threading is not
> used (i.e. there is only 1 worker), and 0 meant that we would
> automatically pick some reasonable parallelism for you (and we
> promise that the our choice would not be outrageously wrong), or
> something like that.

Not just useful, but consistent with other parts of git, like
pack.threads, where "0" already means "autodetect".

-Peff