From: Jeff King <peff@peff.net>
Date: Tue, 03 Nov 2015 22:07:23 GMT
Subject: Re: [PATCH 0/4] diff-highlight: make a few improvements
Message-ID: <20151103220723.GF22484@sigill.intra.peff.net>
In-Reply-To: <1446516334-27652-1-git-send-email-jonathan.lebon@gmail.com>

On Mon, Nov 02, 2015 at 09:05:30PM -0500, Jonathan Lebon wrote:

> These patches bring a few improvements to the contrib/diff-highlight
> Perl script. The major improvement is done in patch 3/4, which improves
> diff-highlighting accuracy by implementing a recursive line matching
> algorithm.
> 
> Please note that I have limited experience with Perl, so there may be
> better ways to do things. (Let me know if that is the case!)

I forgot to mention in the rest of my review: thank you for working on
this, and for making a nice clean series. It was very pleasant to read.

I think the output overall is nicer. I am concerned with the performance
implications. I see this as a stopgap until we have a true diff inside
the hunks, but if we can overcome the performance implications, I think
it's worth applying in the meantime.

-Peff