From: Jeff King Date: Tue, 03 Nov 2015 21:17:16 GMT Subject: Re: [PATCH 2/4] diff-highlight: factor out prefix/suffix functions Message-ID: <20151103211716.GB22484@sigill.intra.peff.net> In-Reply-To: <1446516334-27652-3-git-send-email-jonathan.lebon@gmail.com> On Mon, Nov 02, 2015 at 09:05:32PM -0500, Jonathan Lebon wrote: > In preparation for the next patch, we factor out the functions for > finding the common prefix and suffix between two lines. Looks like a pretty straightforward movement. Your perl adjustments to use array refs look good, and I think the multi-valued return is a good interface. -Peff