From: Knut Franke <k.franke@science-computing.de>
Date: Tue, 27 Oct 2015 08:47:43 GMT
Subject: Re: [PATCH 1/2] http: allow selection of proxy authentication method
Message-ID: <20151027084742.GA6492@science-computing.de>
In-Reply-To: <xmqqk2q9fjyx.fsf@gitster.mtv.corp.google.com>

On 2015-10-26 13:33, Junio C Hamano wrote:
> Call yours "http.proxyAuthmethod" in the documentation, and use
> strcmp("http.proxyauthmethod", var) in the options callback code.
[...]
> Strange indentation here...
[...]
> Along the same line as how we do sslversions[] instead of a long
> if/else if/ chain is preferrable.

Thanks for the feedback, I'll fix these in the next iteration.


Cheers,
Knut
-- 
Vorstandsvorsitzender/Chairman of the board of management:
Gerd-Lothar Leonhart
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Arno Steitz
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Philippe Miltin
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196