From: Tobias Klauser <tklauser@distanz.ch>
Date: Sat, 17 Oct 2015 10:44:25 GMT
Subject: Re: [PATCH 2/3] stripspace: Implement --count-lines option
Message-ID: <20151017104425.GF2468@distanz.ch>
In-Reply-To: <xmqq8u72g1hm.fsf@gitster.mtv.corp.google.com>

On 2015-10-16 at 19:35:49 +0200, Junio C Hamano <gitster@pobox.com> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
> 
> >> So this is your output code, which gives only the number of lines
> >> without the cleaned up result.
> >
> > This should better be a simple printf("%zu\n", lines) I guess?
> 
> I think we actively avoid using %z conversion that is only C99.
> 
> If you really want to, you could count in size_t and use %lu with
> appropriate casting, which I think is what we do in the rest of the
> codebase.
> 
> For this one, I think it is sufficient to just count in int and
> print as int with %d, though.

Ok, will use an int to count and printf("%d\n").