From: Tobias Klauser <tklauser@distanz.ch>
Date: Sat, 17 Oct 2015 10:28:09 GMT
Subject: Re: [PATCH v2 0/4] stripspace: Implement and use --count-lines option
Message-ID: <20151017102809.GB2468@distanz.ch>
In-Reply-To: <vpqsi5a69ey.fsf@grenoble-inp.fr>

On 2015-10-16 at 18:54:45 +0200, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
> 
> >   - Split patch 2/3 into two patches: patch 2/4 switches git stripspace
> >     to use parse-options and patch 3/4 introduces the new option.
> 
> Much better now.
> 
> >   - Implement line counting in cmd_stripbuf() instead of (ab-)using
> >     strbuf_stripspace() for it.
> 
> Also short and sweet, I like it.
> 
> >   - Drop -C short option
> >   - Correct example command output in documentation.
> >   - Adjust commit messages to not include links to the wiki, fully
> >     describe the motivation in the commit message instead.
> 
> Good.
> 
> I read the patches again, and the whole series is now
> 
> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>

Thank you for the review!