From: Tobias Klauser <tklauser@distanz.ch>
Date: Fri, 16 Oct 2015 08:40:19 GMT
Subject: Re: [PATCH 2/3] stripspace: Implement --count-lines option
Message-ID: <20151016084018.GO11304@distanz.ch>
In-Reply-To: <vpqzizkysyh.fsf@grenoble-inp.fr>

On 2015-10-15 at 18:52:54 +0200, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> Tobias Klauser <tklauser@distanz.ch> writes:
> > +static const char * const usage_msg[] = {
> 
> Stick the * to usage_msg please.

Just noticed while looking at how other sub-commands define this, the vast
majority use "const char * const" and not "const char const *".

Also it would change the meaning. The following wouldn't produce a
compiler warning:

	static const char const *usage_msg[] = { ... };
	...
	usage_msg[0] = "Foobar"

while

	static const char * const usage_msg[] = { ... };
	...
	usage_msg[0] = "Foobar"

would produce one:

	builtin/stripspace.c:36:2: error: assignment of read-only location ‘usage_msg[0]’

Even though I don't expect anyone to modify usage_msg at runtime I think
it'd be better to stick with the current version.