From: Tobias Klauser Date: Fri, 16 Oct 2015 07:14:07 GMT Subject: Re: [PATCH 1/3] strbuf: make stripspace() part of strbuf Message-ID: <20151016071406.GK11304@distanz.ch> In-Reply-To: On 2015-10-15 at 18:42:23 +0200, Matthieu Moy wrote: > Tobias Klauser writes: > > > Also switch all current users of stripspace() to the new function name > > and keep a temporary wrapper inline function for topic branches still > > using stripspace(). > > Since you have this temporary wrapper, it would have made sense to split > the patch into 1) move and rename the function, and 2) change the > callsites to strbuf_stripspace. This way 2) would be absolutely trivial > to review. > > OTOH, this patch is already easy to review, so you may consider it's OK > like this. Ok, in this case will keep the patch as is for v2, but with the adjusted commit message as indicated in your and Junio's review. > Reviewed-by: Matthieu Moy Will add it to v2, thanks!