From: Jeff King <peff@peff.net>
Date: Fri, 25 Sep 2015 01:36:35 GMT
Subject: Re: [PATCH 54/68] drop strcpy in favor of raw sha1_to_hex
Message-ID: <20150925013635.GB7522@sigill.intra.peff.net>
In-Reply-To: <CAPig+cQSOoYwG7EKDWPWoB+vHvYWv6ZHg9Zhd8bvH6XKfmG_1w@mail.gmail.com>

On Thu, Sep 24, 2015 at 07:42:05PM -0400, Eric Sunshine wrote:

> On Thu, Sep 24, 2015 at 5:08 PM, Jeff King <peff@peff.net> wrote:
> > In some cases where we strcpy() the result of sha1_to_hex(),
> > there's no need; the result goes directly into a printf
> > statement, and we can simply pass the return value from
> > sha1_to_hex() directly.
> >
> > When this code was originally written, sha1_to_hex used a
> > single buffer, and it was not safe to use it twice within a
> > single expression. That changed as of dcb3450 (sha1_to_hex()
> > usage cleanup, 2006-05-03), but this code ewas never
> 
> s/ewas/was/

Whoops. New content, new errors. :)

-Peff