From: Jeff King <peff@peff.net>
Date: Wed, 16 Sep 2015 22:57:01 GMT
Subject: Re: [PATCH 66/67] use strbuf_complete to conditionally append slash
Message-ID: <20150916225700.GA26015@sigill.intra.peff.net>
In-Reply-To: <xmqqpp1ikm9x.fsf@gitster.mtv.corp.google.com>

On Wed, Sep 16, 2015 at 03:54:50PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> >> Is this conversion correct?  This seems to me that the caller wants
> >> to create an IMAP folder name immediately under the root hierarchy
> >> and wants to have the leading slash in the result.
> >
> > Ugh, you're right. This is the "other" style Eric mentioned earlier.
> >
> > This looks like the only one in the patch (there are many that did not
> > check buf.len at all, but if we assume they were not invoking undefined
> > behavior before, then they are fine under the new code).
> 
> Yes, I should have said that earlier to save one roundtrip.
> 
> Thanks for working on this.

For my re-roll, I've just omitted changing that caller. I think we can
leave it as-is; it is not worth trying to introduce a new helper for the
one site.

-Peff