From: Jeff King Date: Tue, 01 Sep 2015 22:25:29 GMT Subject: Re: [PATCH v2 2/6] date: make "local" orthogonal to date format Message-ID: <20150901222529.GC7862@sigill.intra.peff.net> In-Reply-To: On Tue, Sep 01, 2015 at 03:16:50PM -0700, Junio C Hamano wrote: > John Keeping writes: > > > This is Jeff's original patch with my fixup for DATE_STRFTIME squashed > > in and a new change to reject "raw-local" (in both Documentation/ and > > date.c). > > Even in --date=raw, we do show the timezone offset, so I do not > necessarily agree that raw-local is nonsensical. That's the only > difference between the one I queued yesterday and this one. Yeah, that's why I didn't change it in the original. But to be honest, I cannot imagine any case where that is _useful_, so I do not mind at all to declare it off-limits, even though it is not nonsensical (though it is a little strange to ask for "raw" data and then ask for it to be munged). IOW, I do not mind either way, but the fact that we have to _add_ code to disallow it makes me slightly in favor of allowing it. :) -Peff