From: Jeff King <peff@peff.net>
Date: Tue, 11 Aug 2015 09:38:09 GMT
Subject: Re: [PATCH 05/17] remove hold_lock_file_for_append
Message-ID: <20150811093809.GA10238@sigill.intra.peff.net>
In-Reply-To: <xmqqk2t2u5y9.fsf@gitster.dls.corp.google.com>

On Mon, Aug 10, 2015 at 03:36:14PM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > No users of hold_lock_file_for_append remain, so remove it.
> 
> This does not seem to have anything to do with rotating static buffers
> used in get_pathname(); the only effect it has is to conflict heavily
> with Michael's tempfile topic X-<.

Yeah, the first patch (to drop the final caller) is why I stuck it in
this series, and I did not want to forget the rest of the topic that Jim
worked on.

> Perhaps this should be part of Michael's tempfile topic?

Yes, I think that is OK. We can keep the first patch (to
add_to_alternates_file) here, and do the other one later on top of
Michael's topic.

-Peff