From: Jeff King <peff@peff.net>
Date: Wed, 05 Aug 2015 08:41:48 GMT
Subject: Re: [PATCH v4] clone: simplify string handling in guess_dir_name()
Message-ID: <20150805084147.GC28212@sigill.intra.peff.net>
In-Reply-To: <20150805060852.GA1103@pks-pc.localdomain>

On Wed, Aug 05, 2015 at 08:08:52AM +0200, Patrick Steinhardt wrote:

> > Sadly we cannot just `strip_suffix_mem(repo, &len, "/.git"))` in the
> > earlier code, as we have to account for multiple directory separators. I
> > believe the above code does the right thing, though. I haven't looked at
> > how badly it interacts with the other guess_dir_name work from Patrick
> > Steinhardt that has been going on, though.
> 
> It shouldn't be hard rebasing my work onto this. If it's being
> applied I'll come up with a new version.

Thanks, it is always nice when contributors are flexible and easy to
work with. :)

Hopefully the new tests I've added can help you out, as well.

-Peff