From: Jeff King <peff@peff.net>
Date: Mon, 03 Aug 2015 16:37:28 GMT
Subject: Re: [PATCH v2 5/6] clone: fix hostname parsing when guessing dir
Message-ID: <20150803163727.GA2602@sigill.intra.peff.net>
In-Reply-To: <20150803083414.GA23997@pks-xps.Speedport_W_723V_1_37_000>

On Mon, Aug 03, 2015 at 10:34:14AM +0200, Patrick Steinhardt wrote:

> One more question for backwards compatibility remains then.
> Currently when we clone something like 'http://example.com:2222/'
> we'd create a git repository '2222' as we'd split on the first
> occurrence of ':'. Should we remain backwards compatible here, as
> well, or change the behavior to use 'example.com' as repository
> name?

I don't think naming the repo "2222" makes much sense; I'd consider it a
bug. The only sensible names are "example.com" or "example.com:2222"
(the latter is more specific if you are going to clone the root off of
several different ports, but that seems rather unlikely; the former is
probably what I'd expect).

-Peff