From: Charles Bailey Date: Fri, 17 Jul 2015 17:01:42 GMT Subject: Re: [PATCH] Fix detection of uname failure Message-ID: <20150717170142.GA9616@hashpling.org> In-Reply-To: On Fri, Jul 17, 2015 at 03:06:57PM +0200, Johannes Schindelin wrote: > > From a quick `git grep '== -1'` and another quick `git grep '< 0'` it appears to me that we prefer the latter. Maybe you want to adjust it in the patch, too? I did the same grep and found lots of examples of both. Many of the "< 0" applied to comparisons with variables and not API calls and many were internal (to git) calls and not POSIX or C library calls so I wasn't convinced to change my initial fix. Having said that and thought about it some more, I think '< 0' is probably better. In POSIX, we shouldn't ever get a negative value which isn't -1, but if we ever do it is probably safer to fail. I'll send and update. Charles.