From: Jeff King <peff@peff.net>
Date: Wed, 08 Jul 2015 14:11:11 GMT
Subject: Re: [PATCH 2/2] pack-objects: rename the field "type" to "real_type"
Message-ID: <20150708141110.GA5555@peff.net>
In-Reply-To: <CACsJy8B0OCu3-TKVztj+wCmtqXdeh6iNK5ir4Xi2BXWW14wdOQ@mail.gmail.com>

On Wed, Jul 08, 2015 at 08:57:35PM +0700, Duy Nguyen wrote:

> > The definition of in_pack_type says:
> >
> >>       enum object_type in_pack_type;  /* could be delta */
> >
> > so now I am confused about what exactly "type" (and now "real_type")
> > means.
> 
> I think we just overload "type" with "this delta is detected reusable
> already" in write_object(). It only means 'real type in the output
> pack' for canonical types. For generated deltas, we already know if
> it's ref-delta or ofs-delta, we don't rely on real_type

Ah. I think I'd be inclined to just leave it as "type" then.

-Peff