From: Clemens Buchacher Date: Mon, 06 Jul 2015 08:53:26 GMT Subject: Re: [PATCH] rebase: return non-zero error code if format-patch fails Message-ID: <20150706085326.GA30731@musxeris015.imu.intel.com> In-Reply-To: On Fri, Jul 03, 2015 at 10:52:32AM -0700, Junio C Hamano wrote: > > > > Cc: Andrew Wong > > Signed-off-by: Clemens Buchacher > > Reviewed-by: Jorge Nunes > > Where was this review made? I may have missed a recent discussion, > and that is why I am asking, because Reviewed-by: lines that cannot > be validated by going back to the list archive does not add much > value. Jorge helped me by reviewing the patch before I submitted it to the list. My intention is to give credit for his contribution, and to involve him in any discussion regarding the patch. Maybe it makes more sense to say Helped-by:? Please feel free to change as you see fit. I will follow your recommendation in the future. Thanks.