From: Jeff King <peff@peff.net>
Date: Fri, 03 Jul 2015 18:36:53 GMT
Subject: Re: [PATCH 1/4] list-object: add get_commit_count function
Message-ID: <20150703183653.GA11183@peff.net>
In-Reply-To: <xmqqtwtl3zd7.fsf@gitster.dls.corp.google.com>

On Fri, Jul 03, 2015 at 10:49:40AM -0700, Junio C Hamano wrote:

> Lawrence Siebert <lawrencesiebert@gmail.com> writes:
> 
> > Moving commit counting from rev-list into list-object which is a step
> > toward letting git log do counting as well.
> >
> > Signed-off-by: Lawrence Siebert <lawrencesiebert@gmail.com>
> > ---
> 
> No way.  Look at the things provided by list-objects.c API.  They
> are not about formatting outputs.  printf() calls do not belong
> there.

Moreover, if we are going to provide an abstracted function to show the
commit count, we would also need to provide one to _create_ the count.
IOW, this get_commit_count, wherever it goes, should be accompanied by
the matching code that is put into "show_commit" in patch 2.

-Peff