From: Charles Bailey Date: Mon, 22 Jun 2015 11:38:21 GMT Subject: Re: [PATCH] Add list-all-objects command Message-ID: <20150622113821.GA31118@hashpling.org> In-Reply-To: <20150622083822.GB12259@peff.net> On Mon, Jun 22, 2015 at 04:38:22AM -0400, Jeff King wrote: > On Sun, Jun 21, 2015 at 08:20:31PM +0100, Charles Bailey wrote: > > > + prepare_packed_git(); > > + for (p = packed_git; p; p = p->next) { > > + open_pack_index(p); > > + } > > Yikes. The fact that you need to do this means that > for_each_packed_object is buggy, IMHO. I'll send a patch. I'm glad you said that; the interface did seem a bit warty at the time but as I "fixed" this early in my hacking I didn't remeber to revisit this and ask if it was actually intentional.