From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Fri, 05 Jun 2015 19:42:00 GMT
Subject: Re: Pack files, standards compliance, and efficiency
Message-ID: <20150605194200.GB356121@vauxhall.crustytoothpaste.net>
In-Reply-To: <5571BEA0.2080305@alum.mit.edu>

On Fri, Jun 05, 2015 at 05:22:08PM +0200, Michael Haggerty wrote:
> I don't know that there would necessarily be problems, but I would worry
> about code involving structure assignment. For example, suppose the
> following snippet:
> 
>     void f(struct object_id *oid)
>     {
>         struct object_id oid_copy = *oid;
>         /* ... */
>     }
> 
> The compiler is allowed to implement the copy using instructions that
> rely on proper alignment. Such code would fail if oid is not properly
> aligned.

We use oidcpy which doesn't use object assignment.  I brought that up
previously, and Junio was opposed to doing *dest = *src.  So I don't
think this ends up being an issue.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187