From: Johannes Löthberg <johannes@kyriasis.com>
Date: Fri, 05 Jun 2015 16:25:23 GMT
Subject: Re: [PATCH v2 2/2] t: Add test for cloning from ref namespace
Message-ID: <20150605162523.GA25914@leeloo.kyriasis.com>
In-Reply-To: <20150605161225.GA23368@leeloo.kyriasis.com>

On 05/06, Johannes Löthberg wrote:
>On 05/06, Junio C Hamano wrote:
>>Johannes Löthberg <johannes@kyriasis.com> writes:
>>		git -C ../bare symbolic-ref HEAD >actual &&
>>		echo refs/heads/master >expect &&
>>               test_cmp expect actual &&
>>
>>		git -C ../bare rev-parse HEAD >actual &&
>>               git rev-parse HEAD >expect &&
>>               test_cmp expect actual &&
>>
>>
>
>Hmm, it seems that git-rev-parse doesn't handle GIT_NAMESPACE yet, so 
>can't check it for the namespaced push right now. Not sure if I can 
>fix that myself though.
>

Would it be acceptable to check against 
../bare/refs/namespaces/new_namespace/HEAD and 
../bare/refs/namespaces/new_namespace/refs/heads/master instead, until 
rev-parse is thaught about namespaces?

-- 
Sincerely,
  Johannes Löthberg
  PGP Key ID: 0x50FB9B273A9D0BB5
  https://theos.kyriasis.com/~kyrias/