From: David Aguilar <davvid@gmail.com>
Date: Wed, 20 May 2015 08:53:48 GMT
Subject: Re: [PATCH v4] mergetools: add winmerge as a builtin tool
Message-ID: <20150520085346.GA99001@gmail.com>
In-Reply-To: <CAHGBnuMCvzBYRYgLxz-5QJ5x8Quhw6byf+cGteRXQzpU65B+Jg@mail.gmail.com>

On Wed, May 20, 2015 at 09:47:56AM +0200, Sebastian Schuberth wrote:
> On Wed, May 20, 2015 at 9:42 AM, David Aguilar <davvid@gmail.com> wrote:
> 
> > +       OIFS=$IFS
> > +       IFS='
> > +'
> 
> I guess this is just a formatting issue with the mail export as it should read
> 
> IFS=$'\n'
> 
> Otherwise looks good to me.
> 
> -- 
> Sebastian Schuberth

Thanks for the review.

That's actually a literal newline inside a single-quoted string.

I'm not sure how portable $'\n' is, but the '<literal-newline>'
approach is used often in the git code.
-- 
David