From: Jeff King <peff@peff.net>
Date: Thu, 07 May 2015 16:13:11 GMT
Subject: Re: [PATCH] tests: skip dav http-push tests under NO_EXPAT=NoThanks
Message-ID: <20150507161311.GA26219@peff.net>
In-Reply-To: <xmqqzj5gqsnd.fsf_-_@gitster.dls.corp.google.com>

On Thu, May 07, 2015 at 09:06:14AM -0700, Junio C Hamano wrote:

> When built with NO_EXPAT=NoThanks, we will not have a working http-push
> over webdav.

Hmph, I used to build with NO_EXPAT long ago and don't remember running
into this, but it is clearly broken now. I wonder what bizarre
combination of leftover build products made it work. ;)

> diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
> index 872a252..d823664 100644
> --- a/t/lib-httpd.sh
> +++ b/t/lib-httpd.sh
> @@ -36,6 +36,12 @@ then
>  	test_done
>  fi
>  
> +if test -n "$NO_EXPAT" && test -n "$LIB_HTTPD_DAV"
> +then
> +	skip_all='skipping test, git built without expat support'
> +	test_done
> +fi

I was confused at first why this is in lib-httpd.sh and not 5540, but I
see LIB_HTTPD_DAV is provided by t5540 as a feature flag to
lib-httpd.sh. I learn something new every day about our test
infrastructure.

-Peff