From: Stepan Kasal <kasal@ucw.cz>
Date: Mon, 27 Apr 2015 04:39:00 GMT
Subject: Re: [PATCH/RFC] blame: CRLF in the working tree and LF in the repo
Message-ID: <20150427043900.GC1578@camelia.ucw.cz>
In-Reply-To: <553CD3DA.9090700@web.de>

Hello,

thank you Torsten for the patch [I'm the reporter, but could not do
it myself]

> -test_expect_success 'blaming files with CRLF newlines' '
> +test_expect_failure 'blaming files with CRLF newlines in repo, core.autoclrf=input' '

Shouldn't the old test be rather removed?
It deals with an invalid situation.

I thought that having crlf in the repo is incorrect, so no wonder
that it fails if the files in the working tree are changed to LF.

And changing the autocrlf transformation is effectively the same,
no matter that the files _physically_ are the same as the files in
the repo.

Have a nice day,
    Stepan Kasal