From: Jeff King <peff@peff.net>
Date: Wed, 25 Mar 2015 17:43:19 GMT
Subject: Re: [PATCH 6/8] t: simplify loop exit-code status variables
Message-ID: <20150325174319.GA15096@peff.net>
In-Reply-To: <xmqqfv8t2dii.fsf@gitster.dls.corp.google.com>

On Wed, Mar 25, 2015 at 10:27:49AM -0700, Junio C Hamano wrote:

> > diff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh
> > index 61c1f53..36b10f7 100755
> > --- a/t/t3060-ls-files-with-tree.sh
> > +++ b/t/t3060-ls-files-with-tree.sh
> > @@ -25,15 +25,10 @@ test_expect_success setup '
> >  		do
> >  			num=00$n$m &&
> >  			>sub/file-$num &&
> > -			echo file-$num >>expected || {
> > -				bad=t
> > -				break
> > -			}
> > -		done && test -z "$bad" || {
> > -			bad=t
> > -			break
> > -		}
> > -	done && test -z "$bad" &&
> > +			echo file-$num >>expected ||
> > +			return 1
> > +		done
> > +	done &&
> >  	git add . &&
> >  	git commit -m "add a bunch of files" &&
> 
> The empty initialization for $bad can also go for this one, right?

Yeah, it can.

-Peff