From: Jeff King Date: Wed, 25 Mar 2015 05:25:55 GMT Subject: [PATCH 1/8] perf-lib: fix ignored exit code inside loop Message-ID: <20150325052555.GA31924@peff.net> In-Reply-To: <20150325052456.GA19394@peff.net> When copying the test repository, we try to detect whether the copy succeeded. However, most of the heavy lifting is done inside a for loop, where our "break" will lose the exit code of the failing "cp". We can take advantage of the fact that we are in a subshell, and just "exit 1" to break out with a code. Signed-off-by: Jeff King --- t/perf/perf-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index a8c9574..5cf74ed 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -91,7 +91,7 @@ test_perf_create_repo_from () { */objects|*/hooks|*/config) ;; *) - cp -R "$stuff" . || break + cp -R "$stuff" . || exit 1 ;; esac done && -- 2.3.4.635.gd6ffcfe