From: brian m. carlson Date: Sun, 08 Mar 2015 14:48:16 GMT Subject: Re: [PATCH v2 02/10] Define utility functions for object IDs. Message-ID: <20150308144816.GB4245@vauxhall.crustytoothpaste.net> In-Reply-To: On Sun, Mar 08, 2015 at 04:57:36PM +0700, Duy Nguyen wrote: >On Sun, Mar 8, 2015 at 6:23 AM, brian m. carlson > wrote: >> I'm not very excited about having to put the #include in the middle of >> cache.h. The alternative, of course, is to move enum object_type up, >> which I can do if necessary. Another alternative is to simply move the >> struct object_id definitions to cache.h instead of object.h, which might >> be cleaner. >> >> I'm interested in hearing opinions about the best way to go forward. > >I think declaring struct object_id in cache.h would be simplest. >Another alternative is do it in git-compat-util.h. This is not the >first abuse of git-compat-util.h (because it's included everywhere). >starts_with(), ends_with() and friends are already in >git-compat-util.h cache.h is so ubiquitous due to the hash* functions that I didn't need to include it anywhere, so I don't see a reason to abuse git-compat-util.h for that purpose. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187