From: Caleb Thompson <caleb@calebthompson.io>
Date: Mon, 02 Mar 2015 19:02:33 GMT
Subject: Re: [PATCH v6 0/4] commit: Add commit.verbose configuration
Message-ID: <20150302190233.GB46909@sirius.attlocal.net>
In-Reply-To: <20150227091333.GA32617@pvv.ntnu.no>

Hey Torstein.

I'd planned to come back with a heavily simplified version of this that
didn't include any of the related changes, just the feature and the new
test, since a lot of that seemed controversial.

That said, I haven't done so and you're welcome to take a whack at this
feedback if you'd like.

Caleb Thompson

On Fri, Feb 27, 2015 at 10:13:36AM +0100, Torstein Hegge wrote:
> On Tue, Jun 17, 2014 at 14:38:56 -0500, Caleb Thompson wrote:
> > This patch allows people to set commit.verbose to implicitly send
> > --verbose to git-commit.
> >
> > It introduces several cleanup patches to t/t7505-commit-verbose.sh to
> > bring it closer to the current state of the tests as they have been
> > explained to me, then adds the verbose config and --no-verbose flag.
> >
> > Since the last version of this patch
> > (http://thread.gmane.org/gmane.comp.version-control.git/251486), there
> > have been a couple of commit message clarifications and the body of the
> > check-for-no-diff script in the last patch was changed to simply negate
> > check-for-diff.
>
> Hi Caleb,
>
> Do you intend to work further on this topic? I have been using a similar
> (but less polished) patch, and would like to see this included in Git.
>
> If you don't have time to work on it, I can incorporate the comments on
> this version and submit a v7.
>
>
> Torstein