From: Eric Wong <normalperson@yhbt.net>
Date: Wed, 25 Feb 2015 19:42:13 GMT
Subject: Re: [PATCH] git-svn: fix localtime=true on non-glibc environments
Message-ID: <20150225194213.GA32026@dcvr.yhbt.net>
In-Reply-To: <xmqqfv9tomzx.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:
> Ryuichi Kokubo <ryu1kkb@gmail.com> writes:
> 
> > git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
> > But lowercase %s formatting character is a GNU extention. This causes problem
> > in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
> > Using Time::Local::timelocal($sec, $min, ...) fixes it.
> >
> > Signed-off-by: Ryuichi Kokubo <ryu1kkb@gmail.com>
> 
> Sounds sensible.
> 
> Because we already have "use Time::Local qw(...)" in perl/Git.pm
> that is used by git-svn, we know the platforms that are capable
> of running the current git-svn do have Time::Local available, so
> I do not have worries about new dependency, either.
> 
> Eric?

Looks good, thanks.  Signed-off and queued up.