From: Jeff King <peff@peff.net>
Date: Wed, 18 Feb 2015 18:58:12 GMT
Subject: Re: [PATCH] send-email: ask confirmation if given encoding name is very short
Message-ID: <20150218185812.GC7257@peff.net>
In-Reply-To: <xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com>

On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote:

> Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
> this question:
> 
>     Which 8bit encoding should I declare [UTF-8]?
> 
> We already have a mechanism to avoid accepting a mistyped e-mail
> address (we ask to confirm when the given address lacks "@" in it);
> reuse it to trigger the same confirmation when given a very short
> answer.  As a typical charset name is probably at least 4 chars or
> longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
> prevent such a mistake.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  * Will mark to be merged to 'next'.

Probably belated review, but this looks good to me.

-Peff