From: Jeff King Date: Thu, 29 Jan 2015 15:51:11 GMT Subject: Re: All gnupg tests broken on el4 [Re: [ANNOUNCE] Git v2.3.0-rc2] Message-ID: <20150129155111.GB742@peff.net> In-Reply-To: <20150129154319.GA742@peff.net> On Thu, Jan 29, 2015 at 10:43:20AM -0500, Jeff King wrote: > It feels a bit hacky, and I wish I knew more about why the current file > doesn't work (i.e., if we did "gpg --export-secret-keys" with v1.2.6, > would it produce different output that can be read by both versions?). > Another option is to just declare that version old and broken, and skip > the tests (either by checking its version, or just checking after we > import the keys that we can actually _use_ them). That would look like this: -- >8 -- Subject: [PATCH] t/lib-gpg: sanity-check that we can actually sign Some older versions of gpg (reportedly v1.2.6 from RHEL4) cannot import the keyrings found in our test suite, and thus cannot even make a signature. We can detect this case by doing a test-sign before declaring the GPG prerequisite fulfilled. Signed-off-by: Jeff King --- t/lib-gpg.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh index d88da29..a87747a 100755 --- a/t/lib-gpg.sh +++ b/t/lib-gpg.sh @@ -34,6 +34,8 @@ else "$TEST_DIRECTORY"/lib-gpg/keyring.gpg && gpg --homedir "${GNUPGHOME}" 2>/dev/null --import-ownertrust \ "$TEST_DIRECTORY"/lib-gpg/ownertrust && + gpg --homedir "${GNUPGHOME}" /dev/null 2>&1 \ + --sign -u committer@example.com && test_set_prereq GPG ;; esac -- 2.3.0.rc1.287.g761fd19