From: brian m. carlson Date: Thu, 22 Jan 2015 20:28:02 GMT Subject: Re: [PATCH] Documentation: fix version numbering Message-ID: <20150122202802.GC96498@vauxhall.crustytoothpaste.net> In-Reply-To: <1421955153-14066-1-git-send-email-svenvh@gmail.com> On Thu, Jan 22, 2015 at 07:32:33PM +0000, Sven van Haastregt wrote: >Version numbers in asciidoc-generated content (such as man pages) >went missing as of da8a366 (Documentation: refactor common operations >into variables). Fix by putting the underscore back in the variable >name. > >Signed-off-by: Sven van Haastregt >--- > Documentation/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Documentation/Makefile b/Documentation/Makefile >index 2f6b6aa..3e39e28 100644 >--- a/Documentation/Makefile >+++ b/Documentation/Makefile >@@ -103,7 +103,7 @@ ASCIIDOC_HTML = xhtml11 > ASCIIDOC_DOCBOOK = docbook > ASCIIDOC_CONF = -f asciidoc.conf > ASCIIDOC_COMMON = $(ASCIIDOC) $(ASCIIDOC_EXTRA) $(ASCIIDOC_CONF) \ >- -agit-version=$(GIT_VERSION) >+ -agit_version=$(GIT_VERSION) Yes, this does seem to fix it. My apologies for the bug, and thanks for noticing. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187