From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 23 Dec 2014 20:14:16 GMT
Subject: Re: [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47}
Message-ID: <20141223201416.GA29365@google.com>
In-Reply-To: <20141223084536.GA25190@peff.net>

Jeff King wrote:

> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  t/t1450-fsck.sh | 16 ++++++++++++++++
>  utf8.c          | 17 ++++++++++++-----
>  2 files changed, 28 insertions(+), 5 deletions(-)

Mph.  Sorry I missed this before.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

[...]
> +++ b/t/t1450-fsck.sh
[...]
> +		git fsck 2>err &&
> +		cat err &&
> +		! test -s err

Nit: if this said

		test_line_count = 0 err

then the error message would be more obvious when it fails with
--verbose.

Thanks,
Jonathan