From: Max Kirillov Date: Tue, 09 Dec 2014 05:04:35 GMT Subject: Re: [PATCH v3 0/3] Multiple worktrees vs. submodules fixes Message-ID: <20141209050435.GA9140@wheezy.local> In-Reply-To: <1418100283-8995-1-git-send-email-max@max630.net> On Tue, Dec 09, 2014 at 06:44:40AM +0200, Max Kirillov wrote: > After discussions I came to basically same as v1. > > * Resubmitting the 2 patches which have not been taken to worktrees reroll - > they fix visible issue. Mostly unchanged except small cleanup in test. > * Added GIT_COMMON_DIR to local_repo_env. While it is obviously a right > thing, I wasn't able to observe any change in behavior. > > Max Kirillov (3): > submodule refactor: use git_path_submodule() in add_submodule_odb() > path: implement common_dir handling in git_path_submodule() > Add GIT_COMMON_DIR to local_repo_env > > cache.h | 1 + > environment.c | 1 + > path.c | 24 ++++++++++++++++++++---- > setup.c | 17 ++++++++++++----- > submodule.c | 28 ++++++++++------------------ > t/t7410-submodule-checkout-to.sh | 10 ++++++++++ > 6 files changed, 54 insertions(+), 27 deletions(-) > > -- > 2.2.0.50.gb2b6831 > Should be applied on top of http://thread.gmane.org/gmane.comp.version-control.git/260387 with _all_ patches included, currently it's df56607dff -- Max