From: Jonathan Nieder Date: Thu, 04 Dec 2014 23:53:23 GMT Subject: Re: [PATCH 06/23] expire_reflog(): exit early if the reference has no reflog Message-ID: <20141204235323.GI16345@google.com> In-Reply-To: <1417734515-11812-7-git-send-email-mhagger@alum.mit.edu> Michael Haggerty wrote: > [Subject: expire_reflog(): exit early if the reference has no reflog] The caller moves on to expire other reflogs, so it's not exiting. "return early", maybe? Except the function already returned early. I think the purpose of this patch is to simplify the no-reflog case by handling it separately. Anyway, that's just nitpicking about the subject line. With s/exit/return/ it should be clear that this is a refactoring change, which for someone looking at the shortlog is the important thing. Thanks, Jonathan