From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 04 Dec 2014 23:48:02 GMT
Subject: Re: [PATCH 06/23] expire_reflog(): exit early if the reference has no reflog
Message-ID: <20141204234801.GH16345@google.com>
In-Reply-To: <1417734515-11812-7-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

> --- a/builtin/reflog.c
> +++ b/builtin/reflog.c
> @@ -368,9 +368,11 @@ static int expire_reflog(const char *refname, const unsigned char *sha1, void *c
>  	lock = lock_any_ref_for_update(refname, sha1, 0, NULL);
>  	if (!lock)
>  		return error("cannot lock ref '%s'", refname);
> +	if (!reflog_exists(refname)) {
> +		unlock_ref(lock);
> +		return 0;
> +	}
>  	log_file = git_pathdup("logs/%s", refname);
> -	if (!reflog_exists(refname))
> -		goto finish;

Okay.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>