From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 04 Dec 2014 23:20:54 GMT
Subject: Re: [PATCH 04/23] expire_reflog(): remove unused parameter
Message-ID: <20141204232054.GC16345@google.com>
In-Reply-To: <1417734515-11812-5-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

> It was called "unused", so at least it was self-consistent.

The missing context is that this was a callback function that had to
match the each_ref_fn signature (where that parameter is 'flags')
until v1.5.4~14 (reflog-expire: avoid creating new files in a
directory inside readdir(3) loop, 2008-01-25).  v1.5.4~14 forgot to
clean up.

With or without a note in the commit message explaining that,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>